Update queryAll example #1763
Merged
Update queryAll example #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
requested review from
inancgumus and
heitortsergent
and removed request for
heitortsergent
ankur22
force-pushed
the
update/query-all-example
branch
from
d48a4ea to
4031cad
Compare
inancgumus
reviewed
Oct 7, 2024
docs/sources/next/javascript-api/k6-browser/page/doubledollar.md
Outdated
Show resolved
Hide resolved
inancgumus
approved these changes
Oct 7, 2024
After some feedback from the community, the new example is more valuable than the previous one. Added some more text to help the reader understand when it might be ok to work with this API.
Co-authored-by: İnanç Gümüş <[email protected]>
ankur22
force-pushed
the
update/query-all-example
branch
from
efe48f8 to
75adfe5
Compare
ankur22
requested review from
mstoykov and
olegbespalov
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the example in query all and making it clearer when it's ok to work with
page.$$.After some feedback from the community, the new example is more valuable than the previous one.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
https://community.grafana.com/t/k6-browser-using-locator-on-a-found-element-gives-error-object-has-no-member-locator/133031/5