Test: Verify field immutability for all CRDs #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
theSuess
force-pushed
the
create_immutability_env_tests
branch
from
05e9987 to
1c74663
Compare
theSuess
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to implement tests for immutable fields.
This also allows me to disable the slow Chainsaw Grafana Dashboard immutability test, which has been kept as snippets may be useful for other Chainsaw tests in the future.
I noticed that starting the envtest binaries takes a few seconds(~5), but running the Creates/Patches are almost free and take a few milliseconds.