Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): tls transport nil dereference #1302

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix(client): tls transport nil dereference #1302

merged 2 commits into from
Nov 8, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Nov 8, 2023 •
edited
Loading

That should fix nil deference for tls transport that was accidentaly introduced in #1300

@weisdd weisdd self-assigned this Nov 8, 2023
@weisdd weisdd mentioned this pull request Nov 8, 2023
Closed
NissesSenap
NissesSenap approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weisdd weisdd merged commit 84348de into master Nov 8, 2023
9 checks passed
@weisdd weisdd deleted the fix/tls-transport-nil-dereference branch November 8, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

Assignees

@weisdd weisdd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weisdd @NissesSenap