Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: align labeling of rbac resources #1299

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

siegenthalerroger
Copy link
Contributor

Hopefully fixes: #1298

This PR aligns the labels introduced by #1271 to the same code style as the other labels. I hope that this results in the above issue being fixed.

Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NissesSenap wdyt?

weisdd
weisdd previously requested changes Nov 7, 2023
deploy/helm/grafana-operator/templates/rbac.yaml Outdated Show resolved Hide resolved
deploy/helm/grafana-operator/templates/rbac.yaml Outdated Show resolved Hide resolved
@siegenthalerroger
Copy link
Contributor Author

Yeah sadly I wasn't on a dev machine when I saw the error pop up so I wasn't able to validate that my change would fix it. I'll get round to checking the suggested changes once I have a machine with helm functioning.

@NissesSenap
Copy link
Collaborator

@siegenthalerroger do you have time to look at this some time this week?

@NissesSenap NissesSenap requested a review from weisdd November 14, 2023 13:18
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NissesSenap NissesSenap dismissed weisdd’s stale review November 14, 2023 13:20

The changes has been applied

@NissesSenap NissesSenap enabled auto-merge (squash) November 14, 2023 13:23
@NissesSenap NissesSenap merged commit e4848b5 into grafana:master Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Helm Chart can't be rendered (v5.4.2)
4 participants