Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AzureAD oauth for application registrations #2152

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

callumau
Copy link

@callumau callumau commented Nov 25, 2024

PR Description

Adding the existing prometheus application registration for oauth on Azure

Which issue(s) this PR fixes

Fixes #2150

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

@callumau callumau marked this pull request as ready for review November 26, 2024 10:35
@callumau callumau requested review from clayton-cornell and a team as code owners November 26, 2024 10:35
@mattdurham mattdurham self-assigned this Nov 26, 2024
@callumau
Copy link
Author

Still requires better validation

// Validate OAuth if it is provided

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Prometheus remote write AzureAD oauth
4 participants