Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pod labels to include all labels #2071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jimmybchopps
Copy link

PR Description

Updates the _pod.yaml file to include the same labels used in the DaemonSet/StatefulSet/Deployment to help improve traceability throughout the application. The new labels include the selectorLabels which it was previously using so this should only be adding additional labels and not removing any.

Which issue(s) this PR fixes

#2070

#issue_id

Notes to the Reviewer

PR Checklist

@jimmybchopps jimmybchopps requested a review from a team as a code owner November 12, 2024 17:05
@jimmybchopps
Copy link
Author

@petewall Is there anything specific I need to get this PR to continue its workflow? It's been stuck for a couple of days now at the continuous-integration step and when I click Details it just says to contact the repo admin. :( If there's something I'm missing from my PR, I'm more than happy to address that. Thanks!!!

@mattdurham
Copy link
Collaborator

I approved and kicked off the build.

@jimmybchopps
Copy link
Author

Thanks @mattdurham!!! It looks like I needed to run a script to update the tests. I'm guessing that's why it failed at the previous step, but I think it should be good now.

@jimmybchopps
Copy link
Author

@petewall Any chance you or someone else can take a look at this PR please?

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants