Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe support in Chatbot #10225

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Dataframe support in Chatbot #10225

merged 14 commits into from
Dec 23, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Add Dataframe component support in chatbot. Test with chatbot_core_components demo.

Screenshot 2024-12-18 at 7 16 52 PM

Closes: #8657

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 19, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/gradio-5.9.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 19, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Dataframe support in Chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Thanks @dawoodkhan82 this generally looks good. However, I noticed two issues:

(1) The datatype parameter is not respected. For example, if you modify the chatbot_core_components demo to instead return:

        content = gr.Dataframe(
            interactive=True,
            headers=["One", "Two", "Three"],
            col_count=(3, "fixed"),
            row_count=(3, "fixed"),
            datatype="markdown",
            value=[["abc", "**def**", "ghi"], ["jkl", "mno", "pqr"], ["stu", "vwx", "yz"]],
            label="Dataframe",
        )

you don't get the Markdown rendering that you would expect:

image

(2) There is a thick gray border around the dataframe that shouldn't be there, as you can see in the screenshot above

@abidlabs
Copy link
Member

Still seeing a double border, if you compare the border of the dataframe message with that of other chat messages. Particular prominent in the corners:

Screen.Recording.2024-12-20.at.7.04.31.PM.mov

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs Hmm yeah I noticed that too. I removed the border around the message bubble for dataframe messages. And the only remaining border is the dataframe border itself. Let me take another look.

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs Fixed

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, nice work @dawoodkhan82!

@dawoodkhan82 dawoodkhan82 merged commit f0cf3b7 into main Dec 23, 2024
23 of 24 checks passed
@dawoodkhan82 dawoodkhan82 deleted the dataframe branch December 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Chatbot cannot use gr.Markdown / gr.DataFrame while showing the results
3 participants