-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataframe support in Chatbot #10225
Dataframe support in Chatbot #10225
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/gradio-5.9.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2ceb373d8d9e5e2e25d7ad1c2c815b81368e0707/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Thanks @dawoodkhan82 this generally looks good. However, I noticed two issues: (1) The content = gr.Dataframe(
interactive=True,
headers=["One", "Two", "Three"],
col_count=(3, "fixed"),
row_count=(3, "fixed"),
datatype="markdown",
value=[["abc", "**def**", "ghi"], ["jkl", "mno", "pqr"], ["stu", "vwx", "yz"]],
label="Dataframe",
) you don't get the Markdown rendering that you would expect: (2) There is a thick gray border around the dataframe that shouldn't be there, as you can see in the screenshot above |
Still seeing a double border, if you compare the border of the dataframe message with that of other chat messages. Particular prominent in the corners: Screen.Recording.2024-12-20.at.7.04.31.PM.mov |
@abidlabs Hmm yeah I noticed that too. I removed the border around the message bubble for |
@abidlabs Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, nice work @dawoodkhan82!
Description
Add Dataframe component support in chatbot. Test with
chatbot_core_components
demo.Closes: #8657
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh