Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic PWA support (#38) #78

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

samwisekind
Copy link

@samwisekind samwisekind commented Sep 2, 2024

This PR addresses #38 by adding basic PWA support to the website.

Untitled.mov

Notes:

  • Tried using vite-plugin-pwa but couldn't seem to get it to work properly (i.e. was not generating the manifest)
  • Manifest members scope and start_url are currently set to /gpx.studio/app to limit the PWA to only the new version of the app - this also means that Help and external links such as Donate open in a separate window
  • Used the colour #030816 from the website background for the background and theme colours, as well as the background colour in the icon images (can easily be changed)

Known issues:

  • PWA is not currently installable via Chrome, Edge etc. as it lacks service workers (might be a good next step?)

@vcoppe
Copy link
Contributor

vcoppe commented Sep 2, 2024

Thank you for working on this!
I will replace the current website with the new one in the coming days, so I won't take any action on this until then (the URL will change).

Here are a few comments already:

@samwisekind
Copy link
Author

Thank you for working on this!

I will replace the current website with the new one in the coming days, so I won't take any action on this until then (the URL will change).

Here are a few comments already:

Thanks for the feedback! :) I'll get back to you in a day or two!

@Luen
Copy link

Luen commented Nov 7, 2024

@vcoppe Fireship has a quick video on it. See also their repo (with links to the YouTube videos) - https://github.com/fireship-io/7-pwa-features-demo
Basically, you just need to register a service worker to make it installable on Chromium-based browsers and create a manifest.json
For the languages, you can define a start_url - possibly having a language selector screen on first load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants