Skip to content

Commit

Permalink
fixes issue #2
Browse files Browse the repository at this point in the history
  • Loading branch information
@drossetti
drossetti committed Dec 2, 2016
1 parent a8eb193 commit 306e3f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libmlx5.spec.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Url: http://openfabrics.org/
Source: http://openfabrics.org/downloads/mlx5/%{name}-%{version}.tar.gz
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

BuildRequires: libibverbs-devel >= 1.1-0.1.rc2
BuildRequires: libibverbs-devel >= 1.1.8

This comment has been minimized.

Sign in to view

Copy link
@haggaie

haggaie Jan 17, 2017

Contributor

@alaahl Can we verify that we get the MLNX OFED version of 1.1.8? Because the upstream version 1.1.8 will not have peer_ops.h. Is it 1.1.8mlnx1?

This comment has been minimized.

Sign in to view

Copy link
@alaahl

alaahl Jan 19, 2017

Hi @haggaie , I wouldn't base the requirement on version number, as it will not work once you get a newer upstream version of libibverbs (e.g 1.2.0 will be bigger than 1.1.8mlnx1), in that case the compilation will fail and user will not understand why a header file is missing.. I suggest to update configure script to check that peer_ops.h exists on the system, and fail with error if it's missing.

This comment has been minimized.

Sign in to view

Copy link
@haggaie

haggaie Jan 22, 2017

Contributor

Yes. I guess the correct way to handle this in the distro's dependencies would be to have a different package name for Mellanox OFED packages or something like that.
%if %{_with_valgrind}
BuildRequires: valgrind-devel
%endif
Expand Down

0 comments on commit 306e3f7

Please sign in to comment.