Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all dependencies on exp-verbs #86

Closed
wants to merge 84 commits into from
Closed

Remove all dependencies on exp-verbs #86

wants to merge 84 commits into from

Conversation

pakmarkthub
Copy link
Contributor

@pakmarkthub pakmarkthub commented Jan 21, 2020 •
edited
Loading

This change:

Presubmit Testings:

  • gc11 and PSG Cluster
  • Tests: gds_kernel_latency, gds_kernel_loopback_latency

@pakmarkthub
Removed exp verbs and replaced ibv_exp_create_cq, ibv_exp_create_qp, …
fd13913 
…and ibv_exp_post_send with equivalent direct-verb API or algorithm
@pakmarkthub
Implemented peer-ops with direct-verbs
34bef14
@pakmarkthub
gds_poll_cq now returns wc with correct wr_id
0b1bc41
@pakmarkthub
Fixed the bug that causes auto-inline for message sizes <= 32B
7028d97
@pakmarkthub
Made the code compatible with gdrcopy v1 and v2
91b956f
@pakmarkthub
Added runtime gdrapi version checking
07e9474
@pakmarkthub
Removed unused variables in gds_kernel_latency.c
ecaa221
@pakmarkthub
Removed unused variables in gds_poll_lat.c
2f98818
@pakmarkthub
Removed unused variables in gds_kernel_loopback_latency.c
07c7e79
@pakmarkthub
Reformatted include/gdsync/core.h
f2ddaa3
@pakmarkthub
Reformatted include/gdsync/mlx5.h
762250a
@pakmarkthub
Reformatted include/gdsync/tools.h
cb55b57
@pakmarkthub
Reformatted include/gdsync/device.cuh
36e328d
@pakmarkthub
Reformatted src/archutils.h
3ca44c9
@pakmarkthub
Reformatted src/mlnxutils.h
f0b2390
@pakmarkthub
Reformatted src/apis.cpp
c8856f5
@pakmarkthub
Reformatted src/gdsync.cpp
7c8ec51
@pakmarkthub
Reformatted src/mem.cpp
5a63ed2
@pakmarkthub
Reformatted src/memmgr.cpp
5a57862
@pakmarkthub
Reformatted src/mlx5.cpp
c1e4960
@pakmarkthub
Reformatted src/objs.cpp
8a3f7ed
@pakmarkthub
Reformatted src/objs.hpp
78b83e4
@pakmarkthub
Reformatted src/task_queue.hpp
0d03d1f
@pakmarkthub
Reformatted src/utils.hpp
edfda53
@pakmarkthub
Reformatted tests/gpu.h
0917a19
@pakmarkthub
Reformatted tests/test_utils.h
ec02ba4
@pakmarkthub
Reformatted tests/gds_kernel_latency.c
45f9c2d
@pakmarkthub
Reformatted tests/gds_kernel_loopback_latency.c
ca5cf7f
@pakmarkthub
Reformatted tests/gds_poll_lat.c
9603aa2
@pakmarkthub
Reformatted tests/pingpong.c
a3411c8
This was referenced Feb 3, 2020
Open
Open
Open
@pakmarkthub
Copy link
Contributor Author

I should have fixed/addressed almost all the comments.

@drossetti Please re-review.

@pakmarkthub pakmarkthub requested a review from drossetti February 4, 2020 00:49
pakmarkthub and others added 18 commits April 20, 2020 20:48
@pakmarkthub
Merge branch 'dev-gdrcopy-v2.0' into directverbs-dev
454348e
@pakmarkthub
Added support for all types of opcode and send_flags in gds_mlx5_post…
0bc2084 
…_send
@pakmarkthub
Removed unused code and fixed the error code path in gds_mlx5_post_send
6f93cad
@pakmarkthub
Made struct gds_qp be an attribute of gds_mlx5_qp
26778ed
@pakmarkthub
Moved mlx5-related create qp to gds_mlx5_create_qp
a784aab
@pakmarkthub
Renamed gds_mlx5_qp to gds_mlx5_qp_t
d8a5453
@pakmarkthub
Renamed gds_mlx5_cq to gds_mlx5_cq_t
0fc4ee2
Fixed bug in gds_poll_cq
5a884c0
@pakmarkthub
Implemented IB device type check
8b97bb0
@pakmarkthub
Moved parent domain allocation to gds_mlx5_alloc_parent_domain
51a3e90
@pakmarkthub
Moved mlx5-related create and destroy cq to mlx5.cpp
f9aae49
@pakmarkthub
Fixed bugs in gds_mlx5_alloc_parent_domain
7f4af94
@pakmarkthub
Moved gds_post_ops* to gds_mlx5_post_ops*
fca6c8c
@pakmarkthub
Merge branch 'dev-dv-consolidate-mlx5' into directverbs-dev
fc85eb5
@pakmarkthub
Implemented pd_mem_free
b8bd6b7
@pakmarkthub
Moved mlx5-related poll cq to gds_mlx5_poll_cq
e3492f4
@pakmarkthub
Fixed bug in mlx5_create_wq
38b7560
Bumped version to 3.0
581ffb1
@pakmarkthub
Copy link
Contributor Author

pakmarkthub commented Apr 25, 2020 •
edited
Loading

@drossetti
I made post_send support all types of QP, IBV_WR_*, and IBV_SEND_*. Please take a look if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drossetti drossetti Awaiting requested review from drossetti

Assignees

@drossetti drossetti

@pakmarkthub pakmarkthub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakmarkthub @drossetti