-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAU: Migrate all lambdas to endpoint-module-v2 #5644
Open
whi-tw
wants to merge
13
commits into
main
Choose a base branch
from
whi-tw/BAU/unify-lambda-module-use
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
whi-tw/BAU/unify-lambda-module-use
branch
3 times, most recently
from
December 11, 2024 16:23
2976f62
to
c4f507a
Compare
pskushwaha1
reviewed
Dec 13, 2024
whi-tw
force-pushed
the
whi-tw/BAU/unify-lambda-module-use
branch
from
December 16, 2024 09:31
c4f507a
to
ddf49c5
Compare
whi-tw
force-pushed
the
whi-tw/BAU/unify-lambda-module-use
branch
4 times, most recently
from
December 18, 2024 11:39
6d4dacb
to
40d8d70
Compare
We regularly use the account alias and slack SNS topic arn in other modules. We can make these available as outputs from the shared terraform, to reduce the number of data sources we need to define in other modules.
whi-tw
force-pushed
the
whi-tw/BAU/unify-lambda-module-use
branch
from
December 19, 2024 10:10
40d8d70
to
a917068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
endpoint-module
is quite inefficient, as it does a number of data queries internally. Additionally, all of its' logic is implemented inendpoint-lambda
.I've migrated all our lambdas over to use
endpoint-module-v2
.This new module has the following benefits:
endpoint-lambda
as the lambda-creation engine, which means we have configuration in only one placeAdditionally, I've stopped looking up the account alias and the slack SNS topic within each component, instead retrieving them from shared state. This further reduces the number of
data
lookups.Finally, I've shifted
dynatrace.tf
out of the individual components, and into the parent directory, and have symlinked it in to the individual directories, removing the possibility of different modules getting out of sync.This is the same pattern as we use with
versions.tf
How to review