BAU: Fix flip-flopping resources #5641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
whi-tw/BAU/fix-flip-flopping-resources
branch
5 times, most recently
from
d2ef5e5 to
e0d712a
Compare
Previously, when a P1 alarm was not needed, this would deploy on top of module.account_interventions.aws_cloudwatch_metric_alarm.lambda_error_cloudwatch_alarm so the configuration of the alarm would be modified each time. Now, we only deploy the P1 alarm when required, and it will always be created with a specific name.
This resource should only be set once per account, so it should: - live in `shared`, so multiple components don't try to create it - only be created by the 'primary' environment in the account, so that it's only created once Move the configuration to shared, and then output the role name, so that we can still attach the policies to the role in account-management and oidc.
Some modules have empty sections in their documentation. This change hides those sections to make the documentation more concise.
As-was, this constantly attempted to change the policy resource to 'execute-api:/*', but AWS automatically replaced 'execute-api' with the execution arn. This caused this resource to update on every terraform run.
This replace function is, apparently, non-deterministic. This causes some attributes to be marked as 'known after apply' when they shouldn't. This change adds a new variable, `endpoint_name_sanitized`, which is required if `endpoint_name` contains a period. This variable is then used in place of `endpoint_name` in the resources that were using the `replace` function.
whi-tw
force-pushed
the
whi-tw/BAU/fix-flip-flopping-resources
branch
from
e0d712a to
a67758a
Compare
Also, check all of the modules, not just two of them!
whi-tw
force-pushed
the
whi-tw/BAU/fix-flip-flopping-resources
branch
from
a67758a to
149f7b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A number of our resources have changes in many runs, often unnecessarily.
This PR aims to fix a lot of these.
How to review
Deploy to a dev environment, ensure no weirdness happens
Checklist
Related PRs