BAU: Bump com.nimbusds:oauth2-oidc-sdk from 10.13.2 to 11.20.1 #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhcomer
force-pushed
the
BAU/bump-nimbus
branch
6 times, most recently
from
30df26d to
7c90b85
Compare
alhcomer
force-pushed
the
BAU/bump-nimbus
branch
4 times, most recently
from
db12f4b to
00a9a3f
Compare
|
Bumps [com.nimbusds:oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 10.13.2 to 11.20.1. - [Changelog](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/branches/compare/11.20.1..10.13.2) --- updated-dependencies: - dependency-name: com.nimbusds:oauth2-oidc-sdk dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
ID token claims sets can no longer be created as expired from instantiation. Because of this, the shouldNotFailSignatureValidationIfIdTokenHasExpired test failed as it was trying to create an ID as already expired. I've deleted this test because it is difficult to test without using the sleep method, and the test is testing the functionality of the packages we rely on (nimbus jose and oidc sdk v2) rather than anything to do with our implementation.
alhcomer
force-pushed
the
BAU/bump-nimbus
branch
from
00a9a3f to
9f2c438
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps com.nimbusds:oauth2-oidc-sdk from 10.13.2 to 11.20.1.
updated-dependencies:
What
Had to make changes alongside the upgrade replacing old deprecated methods with new ones, and updating the Token Request instantiation with null values for new optional parameters AuthorizationDetail and DeviceSecret.
See deprecations and replacements here.
See details for new optional AuthorizationDetail TokenRequest parameter here.
See details for device secret
How to review
Checklist
Related PRs