Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minisign verification #70

Closed
wants to merge 1 commit into from

Conversation

desttinghim
Copy link

Attempt to implement #67

I don't know enough about github actions and nodejs to actually test if my code worked.

@goto-bus-stop goto-bus-stop self-requested a review January 29, 2024 09:46
@goto-bus-stop
Copy link
Owner

Thanks for the PR!

I think this will need some work, I can pick that up once I have time to review, as it's in my experience much easier to test an action when you own the repo... It's already very helpful to just have the minisign API calls in there. I'll try to do so this week but can't promise much given my schedule at the moment.

@desttinghim
Copy link
Author

Thanks for the prompt response! :)

I learned a bit since I made the PR. First, I figured out I needed to run npm run prepare for my changes to have an impact. Second, I realized the minisign library relies on sodium-native. This is probably fine, but it will take me a bit more time to figure out how to get all the dependencies to npm install on my nixos development machine.

@desttinghim
Copy link
Author

Closing this version of the PR in favor of #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants