Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added traefik docs #90

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Added traefik docs #90

merged 1 commit into from
Nov 22, 2024

Conversation

TakenMC
Copy link
Contributor

@TakenMC TakenMC commented Nov 18, 2024

No description provided.

jmattheis
jmattheis requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

docs/traefik.md Outdated
```yaml
api:
dashboard: true
insecure: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with having a traefik guide on the website, but I'd want this to be a generic one, so nothing cloudflare specific. With http acme most of the settings aren't needed as it's the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this later

docs/traefik.md Outdated
dashboard: true
insecure: true

entryPoints:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the certificateResolvers for cloudflare, this settings file is pretty small and should be configured as traefik cli arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill fix this later

@TakenMC
Copy link
Contributor Author

TakenMC commented Nov 19, 2024

is this better

jmattheis
jmattheis approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified it more, no need for different docker compose, and the manual creation of the network.

@jmattheis jmattheis merged commit 8cd0ec6 into gotify:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmattheis jmattheis jmattheis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakenMC @jmattheis