Skip to content

Commit

Permalink
Fix typos and style issues (#327)
Browse files Browse the repository at this point in the history
  • Loading branch information
jjliu15 authored Aug 3, 2021
1 parent b36f2f2 commit ba9222c
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# reviewed by someone else.

packages/google_mobile_ads/* @blasten @bparrishMines @jjliu15
.github/ @blasten @bparrishMines @jjliu15
.github/ @blasten @bparrishMines @jjliu15 @luo86
4 changes: 2 additions & 2 deletions packages/google_mobile_ads/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ final NativeAdListener listener = NativeAdListener(

`NativeAds` have an optional argument, `nativeAdOptions`, which can be used to set specific options on the native ad.

`shouldRequestMultipleImages`
`shouldReturnUrlsForImageAssets`
<p>If set to `true`, the SDK will not load image asset content and native ad
image URLs can be used to fetch content. Defaults to false.</p>

Expand Down Expand Up @@ -1389,7 +1389,7 @@ final NativeAdListener listener = NativeAdListener(

`NativeAds` have an optional argument, `nativeAdOptions`, which can be used to set specific options on the native ad.

`shouldRequestMultipleImages`
`shouldReturnUrlsForImageAssets`
<p>If set to `true`, the SDK will not load image asset content and native ad
image URLs can be used to fetch content. Defaults to false.</p>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class FlutterNativeAd extends FlutterAd {
@Nullable private FlutterAdManagerAdRequest adManagerRequest;
@Nullable private Map<String, Object> customOptions;
@Nullable private NativeAdView nativeAdView;
@Nullable private FlutterNativeAdOptions nativeAdOptions;
@Nullable private final FlutterNativeAdOptions nativeAdOptions;

static class Builder {
@Nullable private AdInstanceManager manager;
Expand Down
12 changes: 7 additions & 5 deletions packages/google_mobile_ads/lib/src/ad_containers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -991,15 +991,17 @@ class NativeAdOptions {

/// Options for controlling video playback in supported ad formats.
class VideoOptions {
/// Indicates whether the requested video should have the click to expand
/// behavior.
/// Whether the requested video should have the click to expand behavior.
final bool? clickToExpandRequested;

/// Indicates whether the requested video should have custom controls enabled for
/// play/pause/mute/unmute.
/// Whether the requested video should have custom controls enabled.
///
/// Custom controls are for play/pause/mute/unmute.
final bool? customControlsRequested;

/// Indicates whether videos should start muted. By default this property value is YES.
/// Indicates whether videos should start muted.
///
/// By default this property value is YES.
final bool? startMuted;

/// Constructs a VideoOptions to further customize a native ad request.
Expand Down

0 comments on commit ba9222c

Please sign in to comment.