Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ContinueOnError flag #74

Closed
wants to merge 1 commit into from
Closed

Conversation

r10r
Copy link

@r10r r10r commented Jan 7, 2019

Implements #73 .

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@r10r
Copy link
Author

r10r commented Jan 7, 2019

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@r10r
Copy link
Author

r10r commented Jan 7, 2019

I've added my work email to github email settings.

@googlebot
Copy link

CLAs look good, thanks!

@hanwen
Copy link
Contributor

hanwen commented Jan 7, 2019

can you follow instructions in CONTRIBUTING ?

I usually do code reviews in Gerrit.

thanks!

@r10r
Copy link
Author

r10r commented Jan 7, 2019

done!

Currently tests for the change are missing - I can add them, but this will
take some time.

Btw. one test is already failing in master (without my contribution):

root@shieldos-dev:~/gopath/src/github.com/google/zoekt/build# go test -v .
[...]
=== RUN   TestPartialSuccess
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00000.zoekt: 3299 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00001.zoekt: 3300 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00002.zoekt: 3300 index bytes (overhead 2.9)
2019/01/07 15:08:30 finished /tmp/480465520/repo_v15.00003.zoekt: 3300 index bytes (overhead 2.9)
--- FAIL: TestPartialSuccess (0.01s)
    e2e_test.go:296: got shards [/tmp/480465520/repo_v15.00000.zoekt /tmp/480465520/repo_v15.00001.zoekt /tmp/480465520/repo_v15.00002.zoekt /tmp/480465520/repo_v15.00003.zoekt], want []

@r10r r10r force-pushed the master branch 2 times, most recently from 5a7522f to 44c68b6 Compare January 8, 2019 11:22
…ken / malformed files.

Change-Id: Ic155cb854d367d4a0910dad65b3801303816b08d
@hanwen hanwen closed this May 28, 2019
@r10r r10r deleted the master branch March 24, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants