Make wrapped C++ functions pickleable#30099

Merged

rwgk merged 39 commits intogoogle:mainfrom rwgk:pickle_callable_pywrapcc

Feb 20, 2024

+290-64

Commits on Feb 8, 2024

Add test_*_repr() to test behavior with different Python versions.
Ralf W. Grosse-Kunstleve
committed
Adjust expected repr for PyPy
Ralf W. Grosse-Kunstleve
committed
Adjust another expected repr for PyPy
Ralf W. Grosse-Kunstleve
committed
Try again: undo mistaken adjustment for PyPy
Ralf W. Grosse-Kunstleve
committed
Give up on test_pytypes test_capsule_with_name_repr (not sufficiently important); PyPy still generates 2 different kinds of errors: test_print failure on macOS with Python 3.8; Python 3.9, 3.10 hav…
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 9, 2024

_wrapped_simple_callable proof of concept
Ralf W. Grosse-Kunstleve
committed
Add module_::def_as_native()
Ralf W. Grosse-Kunstleve
committed
Resolve PyPy TypeError: cannot create weak reference to builtin_function_or_method object
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 11, 2024

Replace PyCapsule with function_record_PyObject.
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 12, 2024

function_record_PyTypeObject: Replace C++20 designated initializers with full list of values.
Ralf W. Grosse-Kunstleve
committed
Introduce PYBIND11_DETAIL_FUNCTION_RECORD_ABI_ID and use along with PYBIND11_PLATFORM_ABI_ID_V4 to version function_record_PyTypeObject tp_name
Ralf W. Grosse-Kunstleve
committed
Move std::once_flag out of inline function (in hopes that that fixes flaky behavior of test_gil_scoped.py). IncludeCleaner fixes.
Ralf W. Grosse-Kunstleve
committed
tp_vectorcall was introduced only with Python 3.8
Ralf W. Grosse-Kunstleve
committed
clang-tidy auto-fixes
Ralf W. Grosse-Kunstleve
committed
Disable -Wmissing-field-initializers. Guard PyType_Ready(&function_record_PyTypeObject) also with a simple static bool first_call
Ralf W. Grosse-Kunstleve
committed
Give up on the std::call_once idea, for Python 3.6 compatibility (it works with all other Python versions). Instead call function_record_PyTypeObject_PyType_Ready() from get_internals().
Ralf W. Grosse-Kunstleve
committed
Add __reduce_ex__ to function_record_PyTypeObject. Add _pybind11_detail_function_record_import_helper (proof of concept).
Ralf W. Grosse-Kunstleve
committed
Move function_record_PyTypeObject_PyType_Ready() call in get_internals() so that it is always called when get_internals() is called the first time.
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 13, 2024

gcc 4.8.5 and 7.5.0 reject PYBIND11_WARNING_DISABLE_GCC("-Wmissing-field-initializers")
Ralf W. Grosse-Kunstleve
committed
function_record_PyTypeObject_PyType_Ready(), get_pybind11_detail_function_record_pickle_helper() call-once initializations triggered from cpp_function::initialize_generic()
Ralf W. Grosse-Kunstleve
committed
gcc 4.8.5 and 7.5.0 reject PYBIND11_WARNING_DISABLE_GCC("-Wcast-function-type")
Ralf W. Grosse-Kunstleve
committed
Python 3.6, 3.7: Skip get_pybind11_detail_function_record_pickle_helper() call-once initialization triggered from cpp_function::initialize_generic()
Ralf W. Grosse-Kunstleve
committed
New version of _function_record_pickle_helper, using collections.namedtuple
Ralf W. Grosse-Kunstleve
committed
Explicit str(tup_obj[1]) to fix 🐍 3 • centos:7 • x64 segfault
Ralf W. Grosse-Kunstleve
committed
Factor out detail/function_record_pyobject.h
Ralf W. Grosse-Kunstleve
committed
Use PYBIND11_NAMESPACE_BEGIN/END for function_record_PyTypeObject_methods
Ralf W. Grosse-Kunstleve
committed
Factor out function_record_PyTypeObject_methods::tp_name_impl, mainly to stop clang-format from breaking up a string literal.
Ralf W. Grosse-Kunstleve
committed
Simplify implementation of UNEXPECTED CALL functions.
Ralf W. Grosse-Kunstleve
committed
Factor out detail::get_scope_module()
Ralf W. Grosse-Kunstleve
committed
IncludeCleaner fixes (Google toolchain).
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 14, 2024

Comment out unreachable code (to resolve MSVC Werrors).
Ralf W. Grosse-Kunstleve
committed
Use built-in eval() instead of function_record_pickle_helper()
Ralf W. Grosse-Kunstleve
committed
Remove function_record_pickle_helper()
Ralf W. Grosse-Kunstleve
committed
Mark internals::function_record_capsule_name as OBSOLETE.
Ralf W. Grosse-Kunstleve
committed
Add comment pointing to google#30099
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 16, 2024

Archive experimental code from video meet with @rainwoodman 2024-02-15
Ralf W. Grosse-Kunstleve
committed
Add a pickle roundtrip test starting with m.simple_callable.__self__ and a long comment to explain the unusual behavior.
Ralf W. Grosse-Kunstleve
committed
PyPy does not have m.simple_callable.__self__
Ralf W. Grosse-Kunstleve
committed

Commits on Feb 20, 2024

Change "UNUSUAL" comment as suggested by @rainwoodman (only very slightly differently as suggested).
Ralf W. Grosse-Kunstleve
committed