Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix Implemented try-with-resources for URLClassLoader in the class… #7301

Closed
wants to merge 1 commit into from
Closed

BugFix Implemented try-with-resources for URLClassLoader in the class… #7301

wants to merge 1 commit into from

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Jul 10, 2024

… FinalizableReferenceQueue

Copy link

google-cla bot commented Jul 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dk2k
Copy link
Contributor Author

dk2k commented Jul 10, 2024

CLA was provided and it's details include my email for github

@eamonnmcmanus eamonnmcmanus self-assigned this Jul 10, 2024
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Since finalizers are deprecated for removal, we expect that FinalizableReferenceQueue will eventually disappear too. But meanwhile this is an improvement. I'm going to run this against all of Google's internal tests just to be on the safe side, but I don't expect there will be any issues.

Because of the way the Guava source code is managed, this PR will be superseded by another one coming from our internal source repo. You will be credited.

copybara-service bot pushed a commit that referenced this pull request Jul 11, 2024
Closes #7301.

RELNOTES=n/a
PiperOrigin-RevId: 651126936
copybara-service bot pushed a commit that referenced this pull request Jul 11, 2024
Closes #7301.

RELNOTES=n/a
PiperOrigin-RevId: 651126936
copybara-service bot pushed a commit that referenced this pull request Jul 11, 2024
Closes #7301.

RELNOTES=n/a
PiperOrigin-RevId: 651126936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants