Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copying multiple platforms. #1939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ameir
Copy link

@ameir ameir commented May 6, 2024

crane index filter is a great way to copy multi-platform images without copying undesired platforms. Unfortunately, that command requires that the source image support multiple platforms (i.e., has a manifest list/index). In a scenario where you may be programmatically copying images, some source images may not host a manifest list/index, and additional checks must be performed to decide between crane index filter and crane copy.

This PR updatescrane copy so that it behaves similar to crane index filter, but does not require a manifest list/index. In a single-platform scenario, it behaves much as it did before. In a multi-platform scenario, it filters the manifest list/index to the desired platforms, and copies only those layers.

Example command:

crane copy --platform linux/amd64 --platform linux/arm64 redis localhost:58273/redis

Copy link

google-cla bot commented May 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Sep 4, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@ameir
Copy link
Author

ameir commented Oct 2, 2024

@imjasonh / @jonjohnsonjr do either of you have cycles to take a look at this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant