Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: rename interface{} to any #3515

Merged
merged 1 commit into from
Dec 14, 2024
Merged

all: rename interface{} to any #3515

merged 1 commit into from
Dec 14, 2024

Conversation

jba
Copy link
Contributor

@jba jba commented Dec 14, 2024

All modules are on a Go version after 1.18, so we can rename
interface{} to any to modernize the code.

docstore is omitted, because there are PRs in flight that this might
conflict with (#3500, #3508).

All modules are on a Go version after 1.18, so we can rename
interface{} to any to modernize the code.

docstore is omitted, because there are PRs in flight that this might
conflict with (#3500, #3508).
@jba jba requested a review from vangent December 14, 2024 14:19
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 87.15596% with 28 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (61f69d3) to head (5cd47b9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pubsub/azuresb/azuresb.go 0.00% 10 Missing ⚠️
blob/memblob/memblob.go 16.66% 2 Missing and 3 partials ⚠️
pubsub/mempubsub/mem.go 42.85% 2 Missing and 2 partials ⚠️
blob/blob_fs.go 0.00% 3 Missing ⚠️
blob/driver/driver.go 50.00% 2 Missing ⚠️
blob/azureblob/azureblob.go 90.90% 1 Missing ⚠️
blob/fileblob/fileblob.go 87.50% 0 Missing and 1 partial ⚠️
samples/gocdk-runtimevar/main.go 50.00% 1 Missing ⚠️
samples/gocdk-secrets/main.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
- Coverage   73.26%   73.26%   -0.01%     
==========================================
  Files         113      113              
  Lines       15065    15065              
==========================================
- Hits        11038    11037       -1     
- Misses       3261     3262       +1     
  Partials      766      766              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 9e81e8d into master Dec 14, 2024
11 checks passed
@vangent vangent deleted the any branch December 14, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants