protoc-gen-openapi: Select the correct schemas that correspond to the messages used #414
+48
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #392
Before fixing this issue, if
fq_schema_naming = false
and there were duplicates of schema names traversed and formatted from all imported proto files, the wrong message could be selected, even if it was not actually used.Now, when a message of fully-qualified schema named
foo.Contact
is going to be generatd, at the same time, a duplicate short schema likeContact
formatted frombar.Contact
is found (used), so the fully-qualifiedfoo.Contact
will be used.sample:
protoc
arguments:--openapi_opt naming=proto,fq_schema_naming=false,default_response=false
Before:
After: