Refactor gemma/common.cc to improve readability and safety
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
common
branch
3 times, most recently
from
8c2502b to
e01bcd2
Compare
jan-wassenberg
previously approved these changes
Dec 9, 2024
jan-wassenberg
added
the
copybara-import
|
Apologies, I didn't see this PR is targeting main branch. Our import infra does not support that. Please change to dev branch :) |
Use `std::size` for array size calculations. Replace C-style string manipulations with `std::string` methods. Simplify `std::transform` usage for case conversion. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
changed the title
gemma/common.cc to improve readability and safety:gemma/common.cc to improve readability and safety
ericcurtin
dismissed
jan-wassenberg’s stale review
The base branch was changed.
jan-wassenberg
removed
the
copybara-import
|
Thanks, it's against dev now |
|
Thanks for rebasing :) I think the email address used is not covered by CLA? |
|
Author: @a-googler <no****ly@google.com> apparent didnt sign the CLA, dunno what that means :) |
|
Oh, I see. No idea how that a-googler got into the check. It might help to close this PR and open a new one? Sorry about the incidental complexity :( |
|
No problem 😄 |
|
New PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::sizefor array size calculations. Replace C-style string manipulations withstd::stringmethods. Simplifystd::transformusage for case conversion.