Make SourceProfileFunction as a Protocol.
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_707541015
branch
from
9452259 to
0ab1a7e
Compare
Drive-by: - fix the broken type check in the auto SourceBuilder builder. Currently all types are stringified (with `from __future__ import annotations`) so this branch isn't hit anyway. In a follow up we will replace this flexible logic with logic that just checks the runtime params and model func explicitly (rather than the general `Builder` logic we have currently). PiperOrigin-RevId: 709312703
copybara-service
bot
force-pushed
the
test_707541015
branch
from
0ab1a7e to
ccdef07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
SourceProfileFunctionas aProtocol.Drive-by:
from __future__ import annotations) so this branch isn't hit anyway. In a follow up we will replace this flexible logic with logic that just checks the runtime params and model func explicitly (rather than the generalBuilderlogic we have currently).