Allow Sources to accept multiple model functions. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_706769008
branch
3 times, most recently
from
afa948f to
af68785
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_706769008
branch
5 times, most recently
from
237128a to
18f5d0a
Compare
This modifies the sources registry to register a dict of model functions. These will be tied to runtime params and either autocreate a builder (or a given source builder class can be provided that will be used) Follow up changes to: - move all `function`s to be used through `model_func`. - remove `function` and `affected_core_profiles`. - add a `Protocol` for `SourceProfileFunctions` that will define the interface. - open the registry to accept new model functions. PiperOrigin-RevId: 709309449
copybara-service
bot
force-pushed
the
test_706769008
branch
from
18f5d0a to
0ccedf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Sources to accept multiple model functions.
This modifies the sources registry to register a dict of model functions. These will be tied to runtime params and either autocreate a builder (or a given source builder class can be provided that will be used)
Follow up changes to:
functions to be used throughmodel_func.functionandaffected_core_profiles.ProtocolforSourceProfileFunctionsthat will define the interface.