Lazily initialize AdbCallParser in DeviceSettings.
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_688987170
branch
from
e6397d3 to
d37e456
Compare
We only need `AdbCallParser` _after_ `DeviceSettings.__init__()` in `update()` or `get_orientation()`, so we construct it lazily. This allows the simulator to be launched after `DeviceSettings` is constructed. PiperOrigin-RevId: 689057999
copybara-service
bot
force-pushed
the
test_688987170
branch
from
d37e456 to
746e0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily initialize
AdbCallParserinDeviceSettings.We only need
AdbCallParserafterDeviceSettings.__init__()inupdate()or
get_orientation(), so we construct it lazily. This allows the simulator tobe launched after
DeviceSettingsis constructed.