[WIP] Allowing comma-separated slices in ATHENS_GO_BINARY_ENV_VARS #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
I assigned myself so my task manager picks it up, I'm interested in helping here. |
|
@arschles let us know when this is no longer WIP, I'm also happy to pick it up if you're busy. I think it would be a good issue to get out in the next patch release as people have reported that they are blocked by this :) |
|
closed via #1531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
As described in #1404, it's currently impossible to allow for comma-separated lists in the ATHENS_GO_BINARY_ENV_VARS environment variable
How is the fix applied?
I've made the
EnvListtype implement a envconfig custom decoder to accommodate slicesMention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #1404