Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using - instead of _ for Azure blob storage container name in tests #1498

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

arschles
Copy link
Member

What is the problem I am trying to address?

_ is an invalid char in Azure blob store container names.

How is the fix applied?

Using - instead.

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

I'm picking up where @marpio left off in #1366. I've only added one extra tiny commit to finish his PR off. @marpio when you get a chance, can you let me know if this looks ok to you?

Closes #1366

@arschles arschles requested review from marpio and a team December 19, 2019 21:11
@arschles arschles changed the title Azure blob test Using - instead of _ for Azure blob storage container name in tests Dec 19, 2019
@arschles arschles changed the base branch from master to main June 15, 2020 19:21
@manugupt1
Copy link
Member

thanks for the changes. The changes look good to me; but the build for this test is failing @arschles. Seems like a key needs to be updated from what I understand, would you be able to fix it when you get a chance.

@arschles
Copy link
Member Author

@manugupt1 I am about to go on vacation for the rest of the year, but I'll bookmark this and get back to it in the new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants