Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding note about office hours, removing note about developer meetings #1344

Merged
merged 11 commits into from
Oct 23, 2019

Conversation

arschles
Copy link
Member

What is the problem I am trying to address?

docs.gomods.io and the README still reference the developer meetings, but we haven't done those in a few months, and it's unlikely that we'll resume them soon.

How is the fix applied?

I've replaced the developer meetings page (and all links to it) with an office hours page.

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

N/A

@LinuxSuRen @lopezator would you mind checking out the Chinese / Spanish documentation (respectively) and changing the wording in there, when you can?

@LinuxSuRen @lopetazor would you mind checking out the Chinese / Spanish documentation (respectively) and changing the wording in there, when you can?
@arschles arschles requested a review from a team as a code owner August 15, 2019 23:06
@@ -0,0 +1,29 @@
---
title: "Developer Meetings"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title change to 'Office Hours' as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good catch, changing now

@lopezator
Copy link
Contributor

lopezator commented Aug 19, 2019

@arschles "office hours" is a standard term for this kind of meetings or something relative to the athens project? Not sure how to translate this to spanish, if it's a custom term maybe the literal translation could work...

@ghost
Copy link

ghost commented Aug 19, 2019

@lopezator it's a standard concept where an expert makes themselves available for questions. Typically it was something that professors do, so students had time outside of lectures to get further help or understanding. This is actually in their office.

It has been adopted by tech experts and projects to do something similar.

Someone correct me if in wrong, but in this case it is part code walkthrough and part office hours.

Hope that helps.

@lopezator
Copy link
Contributor

@robjloranger thanks! I get it. I think I have now the correct term to translate this into spanish, thanks!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

README.md Outdated
@@ -12,9 +12,9 @@

Welcome to the Athens project! We are a proxy server for the [Go Modules download API](https://docs.gomods.io/intro/protocol/).

|<img src="docs/static/meeting-icon.svg" alt="Developer Meetings" width="20" height="20" />Developer Meetings|
|<img src="docs/static/meeting-icon.svg" alt="Developer Meetings" width="20" height="20" />Office Hours|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set the alt text to Office Hours as well


This is a great opportunity for new community members to get more involved with the project in a low-pressure setting. It's also a great setting for existing community members to gain a deeper understanding into the codebase.

We meet at this [zoom](https://zoom.us/) video Chat URL: [https://arschles.com/zoom](https://arschles.com/zoom)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capital C in Chat seems a little out of place to me


# Logistics

All office hours happen using the [zoom](https://zoom.us) software. Before you come to the meeting, please make sure you have installed the zoom client using this link: https://zoom.us/support/download.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably wrap the /download link in markdown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpreese hugo will automatically turn that into a clickable link. Were you thinking it should have some text instead of the raw URL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, was just referring to the markdown itself. Hugo will translate it, yes, but is slightly more portable. Just a small nit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpreese after a long delay, I updated this 😆 . Can you let me know what you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! LGTM :)

@@ -0,0 +1,29 @@
---
title: "Office Hours"
date: 2018-09-28T10:40:50-07:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the date to be consistent with the old developers-meeting file? As it's a new topic, we may want to consider updating

@arschles
Copy link
Member Author

@jpreese I made changes and a comment to address your comments. Let me know what you think 😀

@lopezator I saw your translation in #1346. Would you be able to make updates according to 8f836fa?

@arschles
Copy link
Member Author

I'm gonna merge this now so that the site doesn't talk about developer meetings any more, and so we can get the Spanish translation in as well.

@jpreese if you have more feedback, can you submit an issue for it and I'll go fix it up?

@arschles
Copy link
Member Author

CI/CD on drone stays pending forever on this PR for some reason, I'm going to merge anyway because this is docs only

@arschles arschles merged commit a565a0d into gomods:master Oct 23, 2019
@arschles arschles deleted the office-hours branch October 23, 2019 14:46
@jpreese
Copy link
Contributor

jpreese commented Oct 23, 2019

Yeah man, no worries. I didn't see anything else noteworthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants