This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
coap_req: fix use alloc/free issues #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix undefined behavior related to free() of uninitialized pointer. Just return early when allocation with golioth_coap_req_new() has failed. Signed-off-by: Marcin Niestroj <[email protected]>
Fix undefined behavior related to free() of uninitialized pointer. Just return early when allocation with golioth_coap_req_new() has failed. Signed-off-by: Marcin Niestroj <[email protected]>
Free 'coap_req' when scheduling it for sending has failed. Signed-off-by: Marcin Niestroj <[email protected]>
|
Visit the preview URL for this PR (updated for commit 2084bc0): https://golioth-zephyr-sdk-doxygen-dev--pr453-coap-req-fixes-mxptsy7t.web.app (expires Thu, 15 Feb 2024 12:54:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a389eefadf4b4b68a539327b3459dd66c142cf49 |
sam-golioth
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix undefined behavior related to
free()of uninitialized pointer. Justreturn early when allocation with
golioth_coap_req_new()has failed.Free
coap_reqwhen scheduling it for sending has failed.