Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

ci: catch ram overflow build failures #447

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

sam-golioth
Copy link
Contributor

Twister treats overflows in the RAM during builds as "skipped" tests instead of errors by default. Enabling the --overflow-as-errors option ensures we can catch overflows in CI.

@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Visit the preview URL for this PR (updated for commit 128ca65):

https://golioth-zephyr-sdk-doxygen-dev--pr447-ci-twister-catch-qw8qgh71.web.app

(expires Tue, 07 Nov 2023 18:07:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a389eefadf4b4b68a539327b3459dd66c142cf49

@sam-golioth sam-golioth marked this pull request as ready for review October 31, 2023 03:20
Copy link
Collaborator

@mniestroj mniestroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

I'd like to have the same flag enabled in .gitlab-ci.yml, but can do that later myself.

Twister treats overflows in the RAM during builds as
"skipped" tests instead of errors by default. Enabling
the `--overflow-as-errors` option ensures we can catch
overflows in CI.

Signed-off-by: Sam Friedman <[email protected]>
@sam-golioth sam-golioth force-pushed the ci_twister_catch_overflow_errors branch from ca8aa5b to 128ca65 Compare October 31, 2023 18:06
@sam-golioth
Copy link
Contributor Author

Great catch!

I'd like to have the same flag enabled in .gitlab-ci.yml, but can do that later myself.

Added!

@sam-golioth sam-golioth merged commit 4013051 into main Oct 31, 2023
12 checks passed
@mniestroj mniestroj deleted the ci_twister_catch_overflow_errors branch November 1, 2023 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants