-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands: fix mismatch in argument error reporting #19
base: master
Are you sure you want to change the base?
Conversation
Also do the initial parsing earlier, to save effort reading the core if we can't proceed. Signed-off-by: Bryan Boreham <[email protected]>
This PR (HEAD: 30a62f1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/567876. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Keith Randall: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-29T23:00:57Z","revision":"46c5795f0e5d1a9df113c6772f6a3aeec26502bd"} Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Keith Randall: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Bryan Boreham: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. |
It was parsing
args[0]
but reporting an error onargs[1]
,which might panic and obscure the error.
Also do the initial parsing earlier, to save effort reading the core
if we can't proceed.