openapi: Add support for external refs #11076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
morysh
force-pushed
the
iss8067_support_external_openai_ref
branch
from
645aa72 to
c3c773c
Compare
alexandear
suggested changes
Jun 9, 2023
tpl/openapi/openapi3/openapi3.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| return ioutil.ReadAll(file) |
There was a problem hiding this comment.
Suggested change
| return ioutil.ReadAll(file) | |
| return io.ReadAll(file) |
ioutil is deprecated. See #10732
alexandear
reviewed
Jun 9, 2023
tpl/openapi/openapi3/openapi3.go
Outdated
Comment on lines
99
to
102
| var relativePath string | ||
|
|
||
| if strings.HasPrefix(url.Path, "./") { | ||
| relativePath = strings.TrimRightFunc(key, func(r rune) bool { return r != '/' }) + strings.TrimPrefix(url.Path, "./") | ||
| } else { | ||
| relativePath = url.Path | ||
| } |
There was a problem hiding this comment.
Suggested change
| var relativePath string | |
| if strings.HasPrefix(url.Path, "./") { | |
| relativePath = strings.TrimRightFunc(key, func(r rune) bool { return r != '/' }) + strings.TrimPrefix(url.Path, "./") | |
| } else { | |
| relativePath = url.Path | |
| } | |
| relativePath := url.Path | |
| if strings.HasPrefix(url.Path, "./") { | |
| relativePath = strings.TrimRightFunc(key, func(r rune) bool { return r != '/' }) + strings.TrimPrefix(url.Path, "./") | |
| } |
alexandear
reviewed
Jun 9, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing defer file.Close()
There was a problem hiding this comment.
just throwing this out there, but it looks like the contributor added the defer file.Close() on line 108
Set IsExternalRefsAllowed to true and provide a ReadFromURIFunc. Fixes gohugoio#8067
morysh
force-pushed
the
iss8067_support_external_openai_ref
branch
from
c3c773c to
8ee09a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set IsExternalRefsAllowed to true and provide a ReadFromURIFunc.
Fixes #8067