-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unify the auth data handle to the decode method #21350
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21350 +/- ##
==========================================
+ Coverage 45.36% 46.21% +0.84%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6416 +367
- Misses 6983 7131 +148
- Partials 301 336 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
866bd85
to
2f52f60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I PR should have a description of the change and a reference to an issue or similar
@Vad1mo I've updated the description and created issue for it, pls take a look again, thanks. |
Signed-off-by: chlins <[email protected]>
2f52f60
to
01a2391
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Abstract a common unified method to ensure that when using a manager to obtain a provider, the auth information is correctly populated.
Issue being fixed
Fixes #21353
Please indicate you've done the following: