Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify the auth data handle to the decode method #21350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chlins
Copy link
Member

@chlins chlins commented Dec 23, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Abstract a common unified method to ensure that when using a manager to obtain a provider, the auth information is correctly populated.

Issue being fixed

Fixes #21353

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0 labels Dec 23, 2024
@chlins chlins requested a review from a team as a code owner December 23, 2024 10:22
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.21%. Comparing base (c8c11b4) to head (01a2391).
Report is 341 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21350      +/-   ##
==========================================
+ Coverage   45.36%   46.21%   +0.84%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6416     +367     
- Misses       6983     7131     +148     
- Partials      301      336      +35     
Flag Coverage Δ
unittests 46.21% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the fix/p2p-instance-manager-decode branch from 866bd85 to 2f52f60 Compare December 23, 2024 10:30
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I PR should have a description of the change and a reference to an issue or similar

@chlins
Copy link
Member Author

chlins commented Dec 24, 2024

@Vad1mo I've updated the description and created issue for it, pls take a look again, thanks.

@chlins chlins force-pushed the fix/p2p-instance-manager-decode branch from 2f52f60 to 01a2391 Compare December 24, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthInfo lost when retrieving p2p provider instances by manager
5 participants