feat: Add Option to Prevent Overlapping Replications of the Same Artifact in Harbor #21347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bupd <[email protected]> Co-authored-by: Maksym Trofimenko <[email protected]>
Signed-off-by: bupd <[email protected]> Co-authored-by: Maksym Trofimenko <[email protected]>
* Adds Skip If Runnning to Replication Policy Signed-off-by: bupd <[email protected]>
* Adds Checkbox in replication policy UI * Updates swagger & sql schema Signed-off-by: bupd <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21347 +/- ##
==========================================
+ Coverage 45.36% 46.12% +0.75%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6403 +354
- Misses 6983 7141 +158
- Partials 301 339 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: bupd <[email protected]>
bupd
force-pushed
the
feat/add-job-skipper
branch
from
6763a2c to
a997836
Compare
|
Thanks, @bupd, for your contribution! I believe this is a valuable new feature for Harbor that should follow the proposal process. There are several questions we need to briefly discuss:
|
Vad1mo
requested changes
Dec 23, 2024
| @@ -7488,6 +7488,10 @@ definitions: | |||
| type: boolean | |||
| description: Whether to enable copy by chunk. | |||
| x-isnullable: true | |||
| skip_if_running: | |||
| type: boolean | |||
| description: Whether to enable skip, if replication already running. | |||
There was a problem hiding this comment.
This text is misleading, clearly explain what this option does, providing enough context, background, and result of enabling this future: e.g "Don't start a new replication until the previous one is terminated"
| @@ -76,6 +76,7 @@ | |||
| "PULL_BASED": "Pull the resources from the remote registry to the local Harbor.", | |||
| "DESTINATION_NAMESPACE": "Specify the destination namespace. If empty, the resources will be put under the same namespace as the source.", | |||
| "OVERRIDE": "Specify whether to override the resources at the destination if a resource with the same name exists.", | |||
| "SKIP_IF_RUNNING": "Specify whether to skip the execution when replication already running.", | |||
There was a problem hiding this comment.
bad wording, intention and outcome not clear
| @@ -560,6 +561,7 @@ | |||
| "ALLOWED_CHARACTERS": "Allowed special characters", | |||
| "TOTAL": "Total", | |||
| "OVERRIDE": "Override", | |||
| "SKIP_IF_RUNNING": "Skip if running", | |||
bupd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a long-standing issue where overlapping replications of the same artifact can occur in Harbor, leading to unnecessary resource consumption and poor performance. By introducing a "Disable parallel replication" checkbox in the replication policy, it ensures that replication tasks for the same policy do not run in parallel, preventing bandwidth overload and queue backups, especially for large artifacts.
Similar Issues
Related Issues
Why do we need this
Changes Made
Disable parallel replicationCheckbox in Replication UI.skip_if_runningcolumn in sql.Screenshots
Todo
Please indicate you've done the following: