Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change commit-msg hook.sh address to right place #21343

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

yuzp1996
Copy link
Contributor

@yuzp1996 yuzp1996 commented Dec 19, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

When I follow the document to set commit hook.sh with command curl https://cdn.jsdelivr.net/gh/tommarshall/[email protected]/hook.sh >.git/hooks/commit-msg && chmod +x.git/hooks/commit-msg, I found that the content in .git/hooks/commit-msg is Moved Permanently. Redirecting to https://cdn.jsdelivr.net/gh/tommarshall/[email protected]/hook.sh.

So I change the address to the moved address.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@yuzp1996 yuzp1996 requested a review from a team as a code owner December 19, 2024 23:40
@yuzp1996
Copy link
Contributor Author

release-note/ignore-for-release

@yuzp1996
Copy link
Contributor Author

Looks like I have no right to label this PR as release-note/ignore-for-release

@Vad1mo Vad1mo added the release-note/ignore-for-release Do not include PR or Issue for release notes label Dec 20, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt
Copy link
Contributor

Thanks but my coporate firewall is blocking the new URL.
If other maintainers have a chance to verify the content of the script it can be approved and merged.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit d7ab265 into goharbor:main Dec 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants