Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export cve permission issue #21327

Merged

Conversation

wy65701436
Copy link
Contributor

The export CVE permission should be included in the project scope, as the API relies on project-level judgment.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

The export CVE permission should be included in the project scope, as the API relies on project-level judgment.

Signed-off-by: wang yan <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.12.0@d26da85). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/common/rbac/const.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21327   +/-   ##
=================================================
  Coverage                  ?   66.09%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114656           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75777           
  Misses                    ?    34731           
  Partials                  ?     4148           
Flag Coverage Δ
unittests 66.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/rbac/const.go 10.63% <0.00%> (ø)

@stonezdj stonezdj merged commit 4204128 into goharbor:release-2.12.0 Dec 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants