Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replication rule message in UI #21299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bupd
Copy link
Member

@bupd bupd commented Dec 9, 2024

Summary

Make Replication Confrimation Message Clear. By shifting focus on replication rule execution.

Title

- Confrim Replication Rule
+ Confrim Replication Rule Execution

Message

- Do you want to replicate rule demo?
+ Do you want to execute replication rule demo?

Changes Made

  • updates Replication Rule Execution confirm message in UI.
  • Since different languages have varying interpretations of 'execution' it's better to update only the English version for now to maintain clarity and consistency across all translations.

Before

before replmsg

After

after replicmsg

Issue being fixed

Fixes #21292

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.27%. Comparing base (c8c11b4) to head (6aa191a).
Report is 340 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21299      +/-   ##
==========================================
+ Coverage   45.36%   46.27%   +0.90%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6415     +366     
- Misses       6983     7109     +126     
- Partials      301      339      +38     
Flag Coverage Δ
unittests 46.27% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@bupd bupd marked this pull request as ready for review December 9, 2024 11:04
@bupd bupd requested a review from a team as a code owner December 9, 2024 11:05
@Vad1mo Vad1mo added area/i18n Related to Translation changes. area/ui labels Dec 9, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some original language description has been translated into English, but it does not make sense.

@bupd
Copy link
Member Author

bupd commented Dec 13, 2024

thanks for pointing out @chlins . The chinese version is already clear so will update only the other languages which is not clear.

* updates replication rule confirm message for execution in UI
* update en-us-lang and es-es-lang with clear focus on execution
* Since different languages have varying interpretations of 'execution'
* Its better to update only the English version

Signed-off-by: bupd <[email protected]>
@Vad1mo Vad1mo requested a review from chlins December 20, 2024 15:12
@Vad1mo Vad1mo enabled auto-merge (squash) December 20, 2024 15:12
@Vad1mo Vad1mo added the target/2.13.0 issues that are targeting v2.13.0 label Dec 20, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. area/ui release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run replication rule message doesn't make sense
5 participants