Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harbor Satellite Adapter to Harbor #21298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bupd
Copy link
Member

@bupd bupd commented Dec 9, 2024

Summary

  • Adds Harbor Satellite Adapter.

This addition enables seamless integration between Harbor and Harbor Satellite, a project designed to extend Harbor container registry to edge locations.

Context

Harbor Satellite is currently hosted on container-registry/harbor-satellite. It aims to bring Harbor container registries to edge environments, ensuring reliable and integrity-checked images even in challenging connectivity situations. The project provides a stateful, standalone satellite registry that functions as both a primary registry for edge locations and as a fallback option when the central Harbor registry is unavailable.

Why this Adapter

This adapter is essential for Harbor Satellite to effectively communicate and work with the Harbor container registry, allowing users to extend their Harbor ecosystem to edge computing environments.

Looking for feedback and suggestions for further improvements.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd mentioned this pull request Dec 9, 2024
5 tasks
@bupd bupd added the replication/adapters related to replication adapters label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (c8c11b4) to head (57b4051).
Report is 339 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21298      +/-   ##
==========================================
+ Coverage   45.36%   46.25%   +0.89%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6413     +364     
- Misses       6983     7113     +130     
- Partials      301      337      +36     
Flag Coverage Δ
unittests 46.25% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@bupd bupd force-pushed the satellite-adp branch 3 times, most recently from c2c7954 to b18e328 Compare December 9, 2024 11:13
* This commit enables us to use harbor with harbor-satellite

Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
@bupd bupd marked this pull request as ready for review December 17, 2024 15:19
@bupd bupd requested a review from a team as a code owner December 17, 2024 15:19
@Vad1mo Vad1mo added the release-note/new-feature New Harbor Feature label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature replication/adapters related to replication adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants