Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postgres script permissions #21007

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

hajnalmt
Copy link
Contributor

@hajnalmt hajnalmt commented Oct 7, 2024

The initdb.sh and the upgrade.sh scripts in the postgres image were not owned by the postgres user, which made them failing with permission denied errors in some local builds.

Comprehensive Summary of your change

Adding the scripts to the appropriate user and fixing the permissions resolved the issue.

Issue being fixed

Fixes #21006

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@hajnalmt hajnalmt requested a review from a team as a code owner October 7, 2024 08:06
@Vad1mo Vad1mo added the release-note/update Update or Fix label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.17%. Comparing base (c8c11b4) to head (2b659b8).
Report is 334 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21007      +/-   ##
==========================================
+ Coverage   45.36%   46.17%   +0.80%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6401     +352     
- Misses       6983     7126     +143     
- Partials      301      336      +35     
Flag Coverage Δ
unittests 46.17% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

---- 🚨 Try these New Features:

@hajnalmt
Copy link
Contributor Author

hajnalmt commented Nov 6, 2024

Hello Harbor Team,
Could you merge this in? It's not a big change after all.

@hajnalmt hajnalmt force-pushed the initdb-user-permission-fix branch 2 times, most recently from b1a3cb2 to 61b3161 Compare November 22, 2024 09:02
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev enabled auto-merge (squash) November 25, 2024 08:59
The initdb.sh and the upgrade.sh scripts in the postgres image
were not owned by the postgres user, which made them failing
with permission denied errors.

Signed-off-by: Mate Hajnal <[email protected]>
auto-merge was automatically disabled November 25, 2024 09:26

Head branch was pushed to by a user without write access

@hajnalmt hajnalmt force-pushed the initdb-user-permission-fix branch from 61b3161 to 2b659b8 Compare November 25, 2024 09:26
@hajnalmt
Copy link
Contributor Author

Thank you @OrlinVasilev for the auto-merge.
I am sorry, I rebased the PS instead of Merge Commit, so the auto-merge got disabled in the process, can you please enable it again?

@OrlinVasilev OrlinVasilev merged commit 4a12623 into goharbor:main Nov 25, 2024
12 checks passed
@hajnalmt hajnalmt deleted the initdb-user-permission-fix branch November 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants