Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BEDS-536): add re-index-blocks cmd to fix internal transfers status #2965

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

feat(BEDS-536): add re-index-blocks cmd to fix internal transfers status #2965

wants to merge 43 commits into from

Conversation

Tangui-Bitfly
Copy link
Collaborator

  • save when a trace revert an consider that all its child are reverted
  • update transaction view (ref)
image
  • update traces view (ref)
image
  • introduce an unit test, this required few refactoring
    • TieredCacher interface to allow mock
    • RedisClient interface to allow mock
    • SQLReaderDb interface to allow mock
    • InitBigtableWithCache to inject mock dependency
    • type extraction inside types/config.go to simplify test writing

Tangui-Bitfly and others added 19 commits October 1, 2024 14:53
@Tangui-Bitfly
fix(internal transaction): recursively revert traces
190f40e
@Tangui-Bitfly
fix: SQLReaderDb interface missing methods
43144fb
@Tangui-Bitfly
fix(eth1tx): remove transfers if reverted
24087a7
@Tangui-Bitfly
fix(internal tx): only save the highest root revert
5a4c542
@Tangui-Bitfly
ci lint
983aea0
@Monika-Bitfly
feat: updated eth1 proto file
19e6108
@Monika-Bitfly
feat: updated Eth1InternalTransaction in eth1.proto file
a2d8210
@Monika-Bitfly
feat: added Reverted value to Eth1InternalTransactionIndexed
542bc39
@Monika-Bitfly
feat: add check for internal txs while querying the block from erigon…
22303e9 
… node and set the status to 2 if tx has failed partially
@Monika-Bitfly
feat: updated reverted internal txs check logic
3ec42b9
@Tangui-Bitfly
feat(types): add status enum and add status partially executed
bb1d8ab
@Tangui-Bitfly
refactor(client/erigon): simplify transaction indexing flow
bb5ec81
@Tangui-Bitfly
feat(client/erigon): rework geth traces
1127a6f
@Tangui-Bitfly
fix: lint
c1a27cd
@Monika-Bitfly
feat: add status to Eth1TransactionIndexed msg and update hash format…
2a0a2fa 
…ting
@Monika-Bitfly
fix: updated internal tx handling in GetBlock func
87bc9a3
@Monika-Bitfly
fix: updated internal txs parsing in GetBlock
93e492a
@Monika-Bitfly
fix: optimise the memory of internla tx parsing
793b638
@Monika-Bitfly
Merge branch 'BEDS-536/fix-internal-transfers-display' of github.com:…
12aba2f 
…gobitfly/eth2-beaconchain-explorer into BEDS-536/fix-internal-transfer-merge
@Tangui-Bitfly Tangui-Bitfly mentioned this pull request Oct 8, 2024
Closed
Monika-Bitfly
Monika-Bitfly reviewed Oct 8, 2024
View reviewed changes
types/eth1.proto Outdated Show resolved Hide resolved
Tangui-Bitfly and others added 8 commits October 9, 2024 17:47
@Tangui-Bitfly
fix(internal): remove revert + status logic from client to transformers
abaaae2
@Tangui-Bitfly
test(internal): test for revert transformer on tx and itx
0dcaa74
@Tangui-Bitfly
feat(cmd): add re-index-blocks cmd
9ad4dde
@Tangui-Bitfly
chore(proto): clean proto Eth1Transaction and Eth1TransactionIndexed
acd149d
@Tangui-Bitfly
fix(TransformItx): empty revertSource + error before skipping
5c033fa
@Monika-Bitfly
feat(BEDS-536): implement misc fix-internal-txs-from-node cmd with …
20a211e 
…batch processing from Erigon node (#2967)

* wip: move itx status parsing logic to transformers func

* wip: implementing fix-internal-txs misc cmd

* wip: updated geth client initialisation

* wip: moved blocks by batch logic to erigon.go

* wip: updated block by number batch call

* updated blocks batch processing

* feat: added transformers for bulk mutations

* fix: save current block height in local variable when performing mutation of the block data

* fix: add check for start and end block flags

* fix: updated erigon client

* fix: add check for batchcall size and return if it's empty

* cleanup unused code

* cleanup

* updated cmd name to fix-internal-txs-from-node

* fix: uncles, blobGasUsed & excessBlobGas parsing

* rm timings, update GetBlocksByBatch func

* fix: revised ReindexITxsFromNode func logic

* fix: update the logic for parsing uncles, BlobGasUsed and ExcessBlobGas
@Tangui-Bitfly
(BEDS-536) Use raw db for resync (#2972)
357057a 
* rpc/erigon: use raw bigtable
* rpc/erigon: use cache raw db
* rpc/erigon: correct path for geth traces
* cmd/reindex: improve performance + fix raw store cache
* rpc/erigon: fix sender address
* db2/store: add remote server + client
@Tangui-Bitfly
fix ci
34ce72c
@Tangui-Bitfly Tangui-Bitfly force-pushed the BEDS-536/fix-internal-transfer-merge branch from 36500aa to 02926ed Compare October 30, 2024 11:39
@Tangui-Bitfly Tangui-Bitfly force-pushed the BEDS-536/fix-internal-transfer-merge branch from f6c5f1f to e4883a5 Compare October 30, 2024 13:44
@Monika-Bitfly Monika-Bitfly changed the title (BEDS-536) Fix internal transfer status feat(BEDS-536): add re-index-blocks cmd to fix internal transfers status Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monika-Bitfly Monika-Bitfly Monika-Bitfly left review comments

@peterbitfly peterbitfly peterbitfly left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tangui-Bitfly @peterbitfly @Monika-Bitfly @guybrush