(BIDS-2330) misc: add command fix-blocks #2730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybrush
force-pushed
the
BIDS-2330/fix-historic-orphan-blocks
branch
2 times, most recently
from
0a510bb to
d30a9db
Compare
guybrush
force-pushed
the
BIDS-2330/fix-historic-orphan-blocks
branch
from
d30a9db to
223c15a
Compare
…30/fix-historic-orphan-blocks
…axValidatorindexForEpoch for epochs<v2schemacuttoff
…e blocks, just warn
…30/fix-historic-orphan-blocks
guybrush
force-pushed
the
BIDS-2330/fix-historic-orphan-blocks
branch
from
2ee9b7d to
e031e71
Compare
D13ce
reviewed
Jan 8, 2024
Comment on lines
+1564
to
+1571
| lastEpoch := uint64(0) | ||
| for _, slot := range slots { | ||
| epoch := utils.EpochOfSlot(slot) | ||
| if epoch != lastEpoch { | ||
| epochs = append(epochs, epoch) | ||
| } | ||
| lastEpoch = epoch | ||
| } |
There was a problem hiding this comment.
Question: With this logic, slots of epoch 0 will not cause epoch 0 to be part of epochs, right?
For the ticket this PR is meant for, this should not cause an issue. But maybe this should be cleaned up nonetheless as you want to keep the PR.
Comment on lines
+1748
to
+1750
| if iEnd > finalizedSlot+1 { | ||
| iEnd = finalizedSlot + 1 | ||
| } |
There was a problem hiding this comment.
Minor: This should also include something like
if iEnd > end {
iEnd = end
}Because right now it could happen that start is something like end - 3 and in that case end would still be iEnd would still result in start + 1000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖[deprecated] Generated by Copilot at 0569bfe
This pull request introduces new commands and fixes for the database and node synchronization. It adds
fix-exec-txsandfix-block-rootscommands tocmd/misc/main.goto correct data inconsistencies. It also improves thedry-runflag functionality and the error handling and concurrency logic in themainpackage.