-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow direct pdf archives #942
Draft
fmartingr
wants to merge
23
commits into
master
Choose a base branch
from
feat/pdf-archiver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 34.74% 35.59% +0.85%
==========================================
Files 61 65 +4
Lines 5322 5557 +235
==========================================
+ Hits 1849 1978 +129
- Misses 3249 3349 +100
- Partials 224 230 +6 ☔ View full report in Codecov by Sentry. |
…feat/pdf-archiver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide PDF archives for bookmarks by directly downloading the file.
Notable changes
ArchiverDomain
ArchiverDomain
initializes a list of archivers that try to match the content type, if it does, that archiver is used. If an error is raised, the next archiver is used and so on.PDFArchiver
: Just downloads the file.WARCArchiver
as a "catch all" (current default)bookmark.archiver
(warc
/pdf
) andarchive_path
.archive_path != ""
Pending
archive_path
for existing bookmarks: iterate over the bookmarks, check if the archive exists and set the path and thearchiver
towarc
.Closes #929