-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:allow authentication using proxy request header #860
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 25.58% 30.40% +4.82%
==========================================
Files 47 63 +16
Lines 5628 4535 -1093
==========================================
- Hits 1440 1379 -61
+ Misses 3989 2934 -1055
- Partials 199 222 +23 ☔ View full report in Codecov by Sentry. |
Love that feature, will make it super nice to integrate behing a Traefik prox with Auth forwarding to Authentik ... thanks for the contribution. |
fef26a9
to
064cc04
Compare
Hey @PterX thanks for keeping this up to date, I have not forgotten about it but I had to fix other things first. Do you think you could add a basic Authelia service to the docker-compose file to ease the testing of this? It's ok if you are not comfortable with that. I'm in the process to set up Authelia in my own environment too so I could get into this once I have that running since this is of interest to me as well. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
- Coverage 34.66% 34.14% -0.52%
==========================================
Files 61 62 +1
Lines 4050 4129 +79
==========================================
+ Hits 1404 1410 +6
- Misses 2424 2497 +73
Partials 222 222 ☔ View full report in Codecov by Sentry. |
Hey @PterX I see you keep updating with latest master, did you missed this comment I made back in the day? It doesn't have to be authelia but some service to easily test this locally or in e2e tests (#816) |
description : #836
Due to improper robot settings, my pr was forcibly updated and the pr was not merged properly.
wrong merge: PterX#4