Change error for context done vs retries exhausted #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moulik245
commented
Oct 31, 2024
| @@ -130,7 +131,7 @@ func (m *Mutex) lockContext(ctx context.Context, tries int) error { | |||
| } | |||
There was a problem hiding this comment.
I don't think it's super accurate to have ErrAllRetriesExhausted even -- if there's an error acquiring the lock after going through all retries, I believe an ErrTaken would be returned on line 130. Not sure about the situation in which line 134 executes: we'd need to have gone through all retries, where on the last retry, there was no error acquiring the lock, but the conditional check on line 117 fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #164