Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental/long-running tests #163

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Dec 13, 2023

This PR investigates why some older detailed tests are now failing.
These (long running) tests are not really maintained any longer and don't run on CI.
However, this bugs me to find them failing... Just to be clear, I have no plan to revive this super-strict test suite that impedes maintainability.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff196e5) 92.40% compared to head (e2ce530) 94.19%.

❗ Current head e2ce530 differs from pull request most recent head 5545d81. Consider uploading reports for the commit 5545d81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   92.40%   94.19%   +1.79%     
==========================================
  Files          22       22              
  Lines        2987     2978       -9     
==========================================
+ Hits         2760     2805      +45     
+ Misses        182      149      -33     
+ Partials       45       24      -21     
Flag Coverage Δ
oldstable 94.12% <ø> (+1.79%) ⬆️
stable 94.19% <ø> (+1.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi changed the title experimental experimental/long-running tests Dec 26, 2023
Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
@fredbi fredbi force-pushed the test/simplify-flags branch from 18504d6 to 5545d81 Compare January 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant