Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concurrent index creation #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dashrews78
Copy link

@dashrews78 dashrews78 commented Dec 20, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

This resolves issue #293. The issue was a prior PR to allow for other options blindly applied the options at the end of the SQL statement. However, concurrently does not go at the end of the SQL statement. Thus #288 broke the usage of concurrently. Used the playground pointing to this change to verify that the fix works without breaking the issue "fixed" in #288.

The playground verification go-gorm/playground#779.

User Case Description

My case is simple. I want to create an index concurrently as the documents state. The documents clearly state that concurrently is an OPTION. https://gorm.io/docs/indexes.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant