fix

callbacks/update.go

@@ -45,42 +45,37 @@ func BeforeUpdate(db *gorm.DB) {
 			if db.Statement.Schema.BeforeUpdate {
 				beforeUpdateInterface, isBeforeUpdateHook = value.(BeforeUpdateInterface)
 			}
-
-			var (
-				called     bool
-				rv         reflect.Value
-				rvSnapshot reflect.Value
-			)
-			if isBeforeSaveHook || isBeforeUpdateHook {
-				called = true
-				// save a snapshot of the struct before the hook was called
-				rv = reflect.Indirect(reflect.ValueOf(value))
-				rvSnapshot = reflect.New(rv.Type()).Elem()
-				rvSnapshot.Set(rv)
+			if !isBeforeSaveHook && !isBeforeUpdateHook {
+				return false
 			}
+
+			// save a snapshot of the struct before the hook was called
+			rv := reflect.Indirect(reflect.ValueOf(value))
+			rvSnapshot := reflect.New(rv.Type()).Elem()
+			rvSnapshot.Set(rv)
+
 			if isBeforeSaveHook {
 				db.AddError(beforeSaveInterface.BeforeSave(tx))
 			}
 			if isBeforeUpdateHook {
 				db.AddError(beforeUpdateInterface.BeforeUpdate(tx))
 			}
 
-			if called {
-				for _, field := range db.Statement.Schema.Fields {
-					if field.PrimaryKey {
-						continue
-					}
-					dbFieldName, ok := field.TagSettings["COLUMN"]
-					if !ok {
-						continue
-					}
-					// compare with the snapshot and update the field if there is a difference
-					if !reflect.DeepEqual(rv.FieldByName(field.Name).Interface(), rvSnapshot.FieldByName(field.Name).Interface()) {
-						db.Statement.SetColumn(dbFieldName, rv.FieldByName(field.Name).Interface())
-					}
+			for _, field := range db.Statement.Schema.Fields {
+				if field.PrimaryKey {
+					continue
+				}
+				dbFieldName, ok := field.TagSettings["COLUMN"]
+				if !ok {
+					continue
+				}
+				// compare with the snapshot and update the field if there is a difference
+				if !reflect.DeepEqual(rv.FieldByName(field.Name).Interface(), rvSnapshot.FieldByName(field.Name).Interface()) {
+					db.Statement.SetColumn(dbFieldName, rv.FieldByName(field.Name).Interface())
 				}
 			}
-			return called
+
+			return true
 		})
 	}
 }