-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restrict sending gnot by default #2667
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
+ Coverage 60.11% 60.15% +0.04%
==========================================
Files 560 561 +1
Lines 74918 75061 +143
==========================================
+ Hits 45039 45155 +116
- Misses 26504 26525 +21
- Partials 3375 3381 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gnoland start --ugnot-locked | ||
|
||
! gnokey maketx send -send "9999999ugnot" -to g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 -gas-fee 1ugnot -gas-wanted 10000000 -broadcast -chainid=tendermint_test test1 | ||
stderr 'account is locked' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ugnot transfer is locked for this account or globally" (the account it not locked)
Sorry, I just left one comment, but I think before reviewing individual lines, we need:
Braindump:
|
NOTE: I've just seen the comment from @moul on the original issue related to this, so parts of this solution may need to be reworked -- #1837 (comment)
BREAKING CHANGE in the sense that GNOT will no longer be transferable by default unless otherwise specified when starting the node.
This PR aims to do the following:
This is the first of two PRs. The next will be to add a mechanism to unlock GNOT transfer restrictions on a per account basis by the account that wishes to be unlocked broadcasting a new type of transaction.
I'm seeking feedback on this before merging, mainly to get some clarification on the following questions:
No docs will be updated as a part of this PR until there has been more of a discussion.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description