fix: handle missing fsp during payment better AB#32262

global-121 · Dec 23, 2024 · 402d17d · 402d17d
1 parent 0bfcd0e
commit 402d17d
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/services/121-service/src/payments/payments.service.ts b/services/121-service/src/payments/payments.service.ts
@@ -330,7 +330,7 @@ export class PaymentsService {
     programFinancialServiceProviderConfigurationName: string,
   ): Promise<string[]> {
     const config =
-      await this.programFinancialServiceProviderConfigurationRepository.findOneOrFail(
+      await this.programFinancialServiceProviderConfigurationRepository.findOne(
         {
           where: {
             name: Equal(programFinancialServiceProviderConfigurationName),
@@ -340,6 +340,14 @@ export class PaymentsService {
         },
       );
 
+    const errorMessages: string[] = [];
+    if (!config) {
+      errorMessages.push(
+        `Missing Program FSP configuration with name ${programFinancialServiceProviderConfigurationName}`,
+      );
+      return errorMessages;
+    }
+
     const requiredConfigurations =
       getFinancialServiceProviderConfigurationRequiredProperties(
         config.financialServiceProviderName,
@@ -349,7 +357,6 @@ export class PaymentsService {
       return [];
     }
 
-    const errorMessages: string[] = [];
     for (const requiredConfiguration of requiredConfigurations) {
       const foundConfig = config.properties.find(
         (c) => c.name === requiredConfiguration,